[
https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510021#comment-13510021
]
Jay Kreps commented on KAFKA-648:
---------------------------------
I actually recommend that we do a full config review and just change not only
things that are poorly capitalized but also things which have inconsistent
naming conventions or that are just confusing. For example 100% of properties
related to segment retention are called log.retention.x EXCEPT for
log.cleanup.interval.mins--why???? Also some times are given in mins or hours
when a more granular time interval might be more useful. Or another:
log.file.size should really be log.segment.size to make it clear that it is the
size of the log segments not the total size of the log. I recommend we just
make a full list of all configs and review them all. It will be boring but
worth it.
> Use uniform convention for naming properties keys for clientId, groupId,
> consumerId, correlationId
> --------------------------------------------------------------------------------------------------
>
> Key: KAFKA-648
> URL: https://issues.apache.org/jira/browse/KAFKA-648
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Swapnil Ghike
>
> Currently, the convention that we seem to use to get a property value in
> *Config is as follows:
> val configVal = property.getType("config.val", ...) // dot is used to
> separate two words in the key and the first letter of second word is
> capitalized in configVal.
> We should use similar convention for groupId, consumerId, clientId,
> correlationId.
> This change will probably be backward non-compatible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
