[
https://issues.apache.org/jira/browse/KAFKA-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530165#comment-13530165
]
Joel Koshy commented on KAFKA-604:
----------------------------------
The rebased patch does not really comment on/address the concern in the
original review - i.e., it breaks a relatively clean
and convenient syntax in the common case (of updating a single timer) to
support updates to multiple timers. It's obviously
not a particularly major issue, but a rung higher than say, a debate over
whitespace/coding style. My only point is that we
should try and avoid making a change that goes from a nice syntax to a rather
inconvenient syntax. For that reason, I'm
more in favor of the change to KafkaTimer in KAFKA-646.
That said, how about the following: both these patches need multiple timer
updates to update an aggregate timer as well
as a specific timer - i.e., up to this point we don't really have a use case
for updating more than two timers simultaneously.
So we can accomplish this case with the following:
aggregatekafkatimer.time {
specifickafkatimer.time {
<code block>
}
}
and avoid any change to KafkaTimer. Does that seem reasonable to you guys?
> Add missing metrics in 0.8
> --------------------------
>
> Key: KAFKA-604
> URL: https://issues.apache.org/jira/browse/KAFKA-604
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Attachments: kafka_604_v1.patch, kafka_604_v2.patch, kafka_604_v3.diff
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> It would be good if we add the following metrics:
> Producer: droppedMessageRate per topic
> ReplicaManager: partition count on the broker
> FileMessageSet: logFlushTimer per log (i.e., partition). Also, logFlushTime
> should probably be moved to LogSegment since the flush now includes index
> flush time.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
