[
https://issues.apache.org/jira/browse/KAFKA-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542321#comment-13542321
]
Jun Rao commented on KAFKA-668:
-------------------------------
The patch doesn't seem to apply on 0.8 for me.
git apply -p1 ~/Downloads/KAFKA-668-v1.patch
error: patch failed: core/src/main/scala/kafka/server/KafkaZooKeeper.scala:43
error: core/src/main/scala/kafka/server/KafkaZooKeeper.scala: patch does not
apply
> Controlled shutdown admin tool should not require controller JMX url/port to
> be supplied
> ----------------------------------------------------------------------------------------
>
> Key: KAFKA-668
> URL: https://issues.apache.org/jira/browse/KAFKA-668
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8, 0.8.1
> Reporter: Joel Koshy
> Fix For: 0.8
>
> Attachments: KAFKA-668-v1.patch
>
>
> The controlled shutdown admin command takes a zookeeper string and also
> requires the user to supply the controller's jmx url/port. This is a bit
> annoying since the purpose of the zookeeper string is to discover the
> controller. The tool should require exactly one of these options. If
> zookeeper is supplied then discover the controller and its jmx port (which
> means we will need to add the jmx port information to zk).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
