[ 
https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549953#comment-13549953
 ] 

Jun Rao commented on KAFKA-683:
-------------------------------

I agree that seeing the whole request is not useful, especially Message, since 
it's binary. Maybe what we should do is to fix the toString() method in each 
request so that it only prints out meaningful info. This can be fixed in a 
separate jira. One benefit of this is that we can remove the extra 
deserialization of those 3 special fields in RequestChannel, which depends on 
all requests having those 3 fields in the same order and seems brittle.
                
> Fix correlation ids in all requests sent to kafka
> -------------------------------------------------
>
>                 Key: KAFKA-683
>                 URL: https://issues.apache.org/jira/browse/KAFKA-683
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Neha Narkhede
>            Priority: Critical
>              Labels: improvement, replication
>         Attachments: kafka-683-v1.patch, kafka-683-v2.patch, 
> kafka-683-v2-rebased.patch
>
>
> We should fix the correlation ids in every request sent to Kafka and fix the 
> request log on the broker to specify not only the type of request and who 
> sent it, but also the correlation id. This will be very helpful while 
> troubleshooting problems in production.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to