[ 
https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558946#comment-13558946
 ] 

Neha Narkhede commented on KAFKA-671:
-------------------------------------

Nullifying the request object seems like a bigger change. I'm wondering about 
the precise impact to GC that these changes will introduce. If the impact is 
just that the objects get garbage collected within 1 iteration of the young gen 
collector VS 2-3 iterations, I would say the performance upside of this change 
is not worth the risk. But if it significantly reduces garbage collected 
overhead, it might be worth looking further into. Even if we have to do this, I 
agree with Sriram that his earlier change is smaller impact than nullifying 
request object and caching a bunch of things to get around it. 
                
> DelayedProduce requests should not hold full producer request data
> ------------------------------------------------------------------
>
>                 Key: KAFKA-671
>                 URL: https://issues.apache.org/jira/browse/KAFKA-671
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8
>            Reporter: Joel Koshy
>            Assignee: Sriram Subramanian
>            Priority: Blocker
>             Fix For: 0.8.1
>
>         Attachments: outOfMemFix-v1.patch
>
>
> Per summary, this leads to unnecessary memory usage.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to