[
https://issues.apache.org/jira/browse/KAFKA-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565631#comment-13565631
]
Neha Narkhede commented on KAFKA-738:
-------------------------------------
Thanks for the new patch. Some more comments -
1. FetchRequest
1.1 Remove unused import import java.util.concurrent.atomic.AtomicInteger
1.2 I thought you wanted to clear the map in the build method. Don't see that
change included in this patch ?
2. FetchRequestBuilder
2.1 It is not ideal to have the SimpleConsumer set the correlation id correctly
on each fetch request. It is better to leave it as it was done before
(increment the correlation id in build()) and just change it to use
Utils.getNextNonNegativeInt.
> correlationId is not set in FetchRequest in AbstractFetcherThread
> -----------------------------------------------------------------
>
> Key: KAFKA-738
> URL: https://issues.apache.org/jira/browse/KAFKA-738
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Jun Rao
> Priority: Blocker
> Labels: p2
> Attachments: kafka-738.patch, kafka-738.patch, kafka-738_v2.patch
>
>
> correlationId is always 0 in FetchRequest in AbstractFetcherThread.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
