[ 
https://issues.apache.org/jira/browse/KAFKA-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Swapnil Ghike updated KAFKA-755:
--------------------------------

    Attachment: kafka-755-v1.patch

This patch standardizes the reading and writing to zookeeper values according 
to the JSON schemas 1 thru 8 defined in the aforementioned wiki. 

The changes in this patch involve a bunch of refactoring to make this 
standardization possible. 

This patch does not touch any other use of JSON-like structures in the code 
that does not involve interacting with zookeeper.

Testing done:
- Unit tests pass.
- Nuke all the zookeeper data. Start kafka server, produce data using a 
producer and start a consumer. Observe the zookeeper data.

It would be good if we could check in this 1st patch and let the system test 
run over it. I will create another patch to make the changes for item 9 and 10 
in the wiki as and when my hands are free of other blockers. 9 and 10 will be 
used only by our tools and are standalone changes in the sense that we can 
simply delete and recreate the related zookeeper namespaces without disturbing 
our clients.
                
> standardizing json values stored in ZK
> --------------------------------------
>
>                 Key: KAFKA-755
>                 URL: https://issues.apache.org/jira/browse/KAFKA-755
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Swapnil Ghike
>            Priority: Blocker
>             Fix For: 0.8
>
>         Attachments: kafka-755-v1.patch
>
>
> Currently, we have the following paths in ZK that stores non-singleton values.
> 1. Topic assignment value:
> /brokers/topics/topic
> { "0": ["0"] }
> 2. LeaderAndISR info:
> /brokers/topics/test/partitions/0/leaderAndISR
> { "ISR":"0,1","leader":"0","controllerEpoch":"1","leaderEpoch":"0" }
> 3. broker registration:
> /brokers/ids/0
> 192.168.1.148:9092:9999
> 4. partition reassignment path
> It would be good if we do the following:
> a. make them true json (e.g., using number as the value for broker/partition, 
> instead of string).
> b. add version support for future growth.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to