[
https://issues.apache.org/jira/browse/KAFKA-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584369#comment-13584369
]
Jun Rao commented on KAFKA-755:
-------------------------------
Thanks for patch v2. A few more comments.
20. Broker: Can we add brokerInfoString in the following exception?
throw new KafkaException("Failed to parse the broker info from zookeeper", t)
21. TopicCount:
21.1 Can we define "white_list" and "black_list" as constants and reference
only the constants instead of the strings?
21.2 Can we rename specialList to subscriptionPattern?
22. Utils: The comment for mapWithSeqValuesToJson() needs to be changed.
Could you rebase too?
> standardizing json values stored in ZK
> --------------------------------------
>
> Key: KAFKA-755
> URL: https://issues.apache.org/jira/browse/KAFKA-755
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Priority: Blocker
> Labels: p1
> Fix For: 0.8
>
> Attachments: kafka-755-v1.patch, kafka-755-v2.patch
>
>
> Currently, we have the following paths in ZK that stores non-singleton values.
> 1. Topic assignment value:
> /brokers/topics/topic
> { "0": ["0"] }
> 2. LeaderAndISR info:
> /brokers/topics/test/partitions/0/leaderAndISR
> { "ISR":"0,1","leader":"0","controllerEpoch":"1","leaderEpoch":"0" }
> 3. broker registration:
> /brokers/ids/0
> 192.168.1.148:9092:9999
> 4. partition reassignment path
> It would be good if we do the following:
> a. make them true json (e.g., using number as the value for broker/partition,
> instead of string).
> b. add version support for future growth.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
