Thanks for the pull request, do you mind attaching the patches to the respective JIRAs ? That is how we review and accept patches in Kafka.
-Neha On Mon, Mar 25, 2013 at 4:37 PM, polymorphic <[email protected]> wrote: > GitHub user polymorphic opened a pull request: > > https://github.com/apache/kafka/pull/3 > > zkclient and scalatest library updates > > Following https://issues.apache.org/jira/browse/KAFKA-826 I forked the > code and included fixes for 2 bugs I reported, > https://issues.apache.org/jira/browse/KAFKA-807 and > https://issues.apache.org/jira/browse/KAFKA-809 > > All tests pass except kafka.log.LogTest which fails on my Mac--I don't > think it is related to the zkclient fix, I could be wrong. > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/polymorphic/kafka trunk > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/kafka/pull/3.patch > > ---- > commit 9699033b90f911dc6c9d7b2b8a733114b84b080a > Author: Dragos Manolescu <[email protected]> > Date: 2013-03-25T22:22:28Z > > Initial commit after fork > > commit 7183a5cd046f25c2eb77efb99a5a2da4d1baadef > Author: Dragos Manolescu <[email protected]> > Date: 2013-03-25T23:04:13Z > > Updated zkclient dependency to 0.2 > > commit 1bf91504f4d16f2343e7003f27f316d33888c931 > Author: Dragos Manolescu <[email protected]> > Date: 2013-03-25T23:34:10Z > > Fixed typo in ConsoleProducer; updated scalatest version for 2.9.2 (if > required) > > ---- >
