[ 
https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630955#comment-13630955
 ] 

Cosmin Lehene edited comment on KAFKA-843 at 4/13/13 6:01 AM:
--------------------------------------------------------------

Attached an addendum (applies over 0.8 with previous patch)
that includes the discussed changes. It complies to Semantic Versioning 
2.0.0-rc.1 (http://semver.org/)

Changes: 
* version includes major minor and patch and pre-release version, hence it's 
0.8.0-SNAPSHOT
* build number is optional and is appended with a plus sign, hence if build 
number is 199 the full version will be 0.8.0-SNAPSHOT+199

I suggest sticking to semantic versioning. It's not anything new, it's just 
very clear and easy to explain and rely on.

Also, handling versioning should probably be done using a release plugin like 
sbt-release (https://github.com/sbt/sbt-release) so we avoid cluttering the 
Build.scala file.


                
      was (Author: clehene):
    Attached an addendum (applies over 0.8 with previous patch)
that includes the discussed changes. It complies to Semantic Versioning 
2.0.0-rc.1 (http://semver.org/)

Changes: 
* version includes major minor and patch and pre-release version, hence it's 
0.8.0-SNAPSHOT
* build number is optional and is appended with a plus sign, hence if build 
number is 199 the full version will be 0.8.0-SNAPSHOT+199

I suggest sticking to semantic versioning. It's not anything new, it's just 
very clear and easy to explain and rely on.

Also, handling versioning should probably be done using a release plugin like 
[https://github.com/sbt/sbt-release|sbt-release] so we avoid cluttering the 
Build.scala file.


                  
> Re-add the release-zip sbt target
> ---------------------------------
>
>                 Key: KAFKA-843
>                 URL: https://issues.apache.org/jira/browse/KAFKA-843
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: packaging
>    Affects Versions: 0.8
>            Reporter: Cosmin Lehene
>            Assignee: Cosmin Lehene
>             Fix For: 0.8
>
>         Attachments: 
> 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch, 
> KAFKA-843.patch, KAFKA-843.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> This target has been removed a while ago.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to