[
https://issues.apache.org/jira/browse/KAFKA-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13671595#comment-13671595
]
Neha Narkhede commented on KAFKA-927:
-------------------------------------
Sriram,
This patch doesn't compile with the following errors -
[error]
/home/nnarkhed/Projects/apache-kafka-git/core/src/main/scala/kafka/server/KafkaApis.scala:133:
not found: type ControlledShutdownRequest
[error] val controlledShutdownRequest =
request.requestObj.asInstanceOf[ControlledShutdownRequest]
[error] ^
[error]
/home/nnarkhed/Projects/apache-kafka-git/core/src/main/scala/kafka/server/KafkaApis.scala:135:
not found: type ControlledShutdownResponse
[error] val controlledShutdownResponse = new
ControlledShutdownResponse(controlledShutdownRequest.correlationId,
[error] ^
[error]
/home/nnarkhed/Projects/apache-kafka-git/core/src/main/scala/kafka/server/KafkaServer.scala:28:
ControlledShutdownResponse is not a member of kafka.api
[error] import kafka.api.{ControlledShutdownResponse, ControlledShutdownRequest}
[error] ^
[error]
/home/nnarkhed/Projects/apache-kafka-git/core/src/main/scala/kafka/server/KafkaServer.scala:157:
not found: type ControlledShutdownRequest
[error] val request = new
ControlledShutdownRequest(correlationId.getAndIncrement, config.brokerId)
[error] ^
[error]
/home/nnarkhed/Projects/apache-kafka-git/core/src/main/scala/kafka/server/KafkaServer.scala:160:
not found: value ControlledShutdownResponse
[error] val shutdownResponse =
ControlledShutdownResponse.readFrom(response.buffer)
[error] ^
> Integrate controlled shutdown into kafka shutdown hook
> ------------------------------------------------------
>
> Key: KAFKA-927
> URL: https://issues.apache.org/jira/browse/KAFKA-927
> Project: Kafka
> Issue Type: Bug
> Reporter: Sriram Subramanian
> Assignee: Sriram Subramanian
> Attachments: KAFKA-927.patch
>
>
> The controlled shutdown mechanism should be integrated into the software for
> better operational benefits. Also few optimizations can be done to reduce
> unnecessary rpc and zk calls. This patch has been tested on a prod like
> environment by doing rolling bounces continuously for a day. The average time
> of doing a rolling bounce with controlled shutdown for a cluster with 7 nodes
> without this patch is 340 seconds. With this patch it reduces to 220 seconds.
> Also it ensures correctness in scenarios where the controller shrinks the isr
> and the new leader could place the broker to be shutdown back into the isr.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
