[
https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13699128#comment-13699128
]
Sam Meder commented on KAFKA-943:
---------------------------------
So we also have a config management system external to the application, but it
has a key space managed by ourselves and we do not expose Kafka properties
directly in that configuration. We also end up not even exposing some of the
Kafka properties, some of them can just be set to reasonable defaults for our
use case and not exposed to our configuration system. As always it is hard to
say how common our use is, but it doesn't strike me as that unusual.
Fair point regarding coupling code & config (we end up deploying code &
configuration in lockstep - they're versioned together). I guess one solution
would be versioning configuration, but that doesn't seem worth the complexity
here.
> Move all configuration key string to constants
> ----------------------------------------------
>
> Key: KAFKA-943
> URL: https://issues.apache.org/jira/browse/KAFKA-943
> Project: Kafka
> Issue Type: Improvement
> Components: config
> Affects Versions: 0.8
> Reporter: Sam Meder
> Attachments: configConstants.patch
>
>
> The current code base has configuration key strings duplicated all over the
> place. They show up in the actual *Config classes, a lot of tests, command
> line utilities and other examples. This makes changes hard and error prone.
> DRY...
> The attached patch moves these configuration keys to constants and replaces
> their usage with a reference to the constant. It also cleans up a few old
> properties and a few misconfigured tests. I've admittedly not written a whole
> lot of Scala, so there may be some improvements that can be made, in
> particular I am not sure I chose the best strategy for keys needed by the
> SyncProducerConfigShared trait (or traits in general).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
