----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14091/#review26140 -----------------------------------------------------------
kafka-patch-review.py <https://reviews.apache.org/r/14091/#comment51047> Just one thing, I am not super comfortable having a password in a file in plain text. - Swapnil Ghike On Sept. 16, 2013, 3:28 a.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14091/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2013, 3:28 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1053 > https://issues.apache.org/jira/browse/KAFKA-1053 > > > Repository: kafka > > > Description > ------- > > 1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2) > Improved error handling to handle the case if the patch is empty 3) Prevent > uploading patch and updating/creating reviewboard if patch is empty or diff > is not checked into local branch > > > Use underscore to separate jira, date and time in patch name > > > Addressed Swapnil's review comments - 1) Closed the file handle for the git > command 2) Removed the --version command line option and automated version to > be the timestamp > > > Included Guozhang's suggestion about making --version mandatory if --rb is > specified > > > Included Guozhang's suggestion about making --version mandatory if --rb is > specified > > > Attaching file using jira-python package > > > Changed the script to use the jira-python package, part 2 > > > Changed the script to use the jira-python package > > > Changed the creating a reviewboard comment as suggested by Tejas > > > Included Tejas's comments > > > Changed the post-review tool to publish the rb automatically. Updated the > tool to add a link to the rb in the JIRA > > > publish automatically > > > Patch review tool > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > kafka-patch-review.py PRE-CREATION > > Diff: https://reviews.apache.org/r/14091/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
