[
https://issues.apache.org/jira/browse/KAFKA-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821554#comment-13821554
]
Jun Rao commented on KAFKA-1112:
--------------------------------
Thanks for the patch. A few comments.
1. I am a bit concerned of depending on a potentially corrupted index to look
for recoveryPoint - 1 in LogSegment.needsRecovery(). If the index points to an
arbitrary position in FileMessageSet, the offset value that
FileMessageSet.searchFor() finds is garbage. If that value happens to be
larger than targetOffset, we will assume that we find targetOffset, but in fact
we haven't.
2. LogTest.testCorruptLog(): Is the println statement needed?
3. Could you rebase?
> broker can not start itself after kafka is killed with -9
> ---------------------------------------------------------
>
> Key: KAFKA-1112
> URL: https://issues.apache.org/jira/browse/KAFKA-1112
> Project: Kafka
> Issue Type: Bug
> Components: log
> Affects Versions: 0.8, 0.8.1
> Reporter: Kane Kim
> Assignee: Jay Kreps
> Priority: Critical
> Attachments: KAFKA-1112-v1.patch, KAFKA-1112.out
>
>
> When I kill kafka with -9, broker cannot start itself because of corrupted
> index logs. I think kafka should try to delete/rebuild indexes itself without
> manual intervention.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
