[
https://issues.apache.org/jira/browse/KAFKA-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830200#comment-13830200
]
Joel Koshy commented on KAFKA-1142:
-----------------------------------
Actually, it did post a diff:
https://reviews.apache.org/r/15793/diff/
Not sure why it did not succeed posting the link to jira.
I used this jira to test:
- Checked out a much older git hash
- Applied the above patch
- The patch review tool now only shows the diff from that older git hash (i.e.,
the divergent point)
I think it is good to do this on 0.8 as well - just to avoid patches that
accidentally delete old commits.
> Patch review tool should take diff with origin from last divergent point
> ------------------------------------------------------------------------
>
> Key: KAFKA-1142
> URL: https://issues.apache.org/jira/browse/KAFKA-1142
> Project: Kafka
> Issue Type: Bug
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Attachments: KAFKA-1142.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
