----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review30236 -----------------------------------------------------------
core/src/main/scala/kafka/controller/KafkaController.scala <https://reviews.apache.org/r/15711/#comment57883> Currently, all admin tools depend on state changes like preferred replica election/partition reassignment go through zookeeper. This helps the tools build a progress report. I think the ideal end state is still an admin RPC, but until we have that, it will be worth investigating if we can keep that property in this patch. core/src/main/scala/kafka/controller/KafkaController.scala <https://reviews.apache.org/r/15711/#comment57884> If a massive admin-triggered preferred replica election is in progress, this callback might wait on the controller lock. If it waits until the next time the callback has to be triggered, the thread pool will wait to get the next task as there is no available thread to execute it (as the thread pool size is 1). I wonder if we should just return from the callback if a preferred replica election is in progress? core/src/main/scala/kafka/server/KafkaConfig.scala <https://reviews.apache.org/r/15711/#comment57885> This is a config that we may not need in the future once we are sure that the zookeeper callbacks work fine in the controller. In that case, could we just depend on imbalance.check.interval.seconds to turn this feature on/off? As discussed offline - overall, looks good. Just have a few suggestions on this patch that we should think about. - Neha Narkhede On Dec. 10, 2013, 6:52 a.m., Sriram Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15711/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 6:52 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-930 > https://issues.apache.org/jira/browse/KAFKA-930 > > > Repository: kafka > > > Description > ------- > > Address code review feedbacks > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > > commit missing code > > > some more changes > > > fix merge conflicts > > > Add auto leader rebalance support > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > trunk > > Conflicts: > core/src/main/scala/kafka/admin/AdminUtils.scala > core/src/main/scala/kafka/admin/TopicCommand.scala > > change comments > > > commit the remaining changes > > > Move AddPartitions into TopicCommand > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 4c319aba97655e7c4ec97fac2e34de4e28c9f5d3 > core/src/main/scala/kafka/server/KafkaConfig.scala > b324344d0a383398db8bfe2cbeec2c1378fe13c9 > > Diff: https://reviews.apache.org/r/15711/diff/ > > > Testing > ------- > > > Thanks, > > Sriram Subramanian > >
