> On Dec. 18, 2013, 9:57 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/admin/TopicCommand.scala, line 75 > > <https://reviews.apache.org/r/16356/diff/1/?file=399581#file399581line75> > > > > We need to check if the value is a single topic string here.
Guozhang, thanks for pointing out the 'trivial' whitelist feature. It turns out that if you specify a trivial whitelist during the --create option, the create topic fails with the following relevant error - nnarkhed-mn1:kafka-git-idea nnarkhed$ ./bin/kafka-topics.sh --zookeeper localhost:2181 --topic "test12,test13" --create --partitions 1 --replication-factor 1 (Error while executing topic command,kafka.common.InvalidTopicException: topic name test12,test13 is illegal, contains a character other than ASCII alphanumerics, '.', '_' and '-') So I think we are covered here - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16356/#review30648 ----------------------------------------------------------- On Dec. 18, 2013, 9:33 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16356/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 9:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1139 > https://issues.apache.org/jira/browse/KAFKA-1139 > > > Repository: kafka > > > Description > ------- > > Changes include 1) Added the ability to accept regular expressions on the > --topic option for the topic tool. That eased testing for this feature and is > useful in general for changing topic configs in bulk 2) Changed the topic > listener on the consumer to queue up the rebalance event instead of > explicitly invoking a rebalance > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > d25aae3cc029b530cc589d4147499a9586dc6e7d > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > 0cc236af2852446e2d6e84956c34370fb4a2a166 > > Diff: https://reviews.apache.org/r/16356/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
