----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16579/#review31140 -----------------------------------------------------------
Looks good. Just one comment. core/src/main/scala/kafka/admin/TopicCommand.scala <https://reviews.apache.org/r/16579/#comment59494> Could we print both the message string and the stack trace of the exception? We can use Utils.stackTrace(). - Jun Rao On Jan. 2, 2014, 11:10 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16579/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2014, 11:10 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1198 > https://issues.apache.org/jira/browse/KAFKA-1198 > > > Repository: kafka > > > Description > ------- > > Dummy > > > KAFKA-1198.v1 > > > Diffs > ----- > > core/src/main/scala/kafka/admin/TopicCommand.scala > 083fd632f66c0b48d3d8fe75f3820f8b0e40d291 > > Diff: https://reviews.apache.org/r/16579/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
