[ 
https://issues.apache.org/jira/browse/KAFKA-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867405#comment-13867405
 ] 

Guozhang Wang commented on KAFKA-404:
-------------------------------------

Thanks for v3. A few more comments:

1. There is one function makeSurePersistentPathExists in ZkUtils, which we can 
reuse to replace the for-loop-createPersistent code.

2. With the above function, we can do something like Joel suggested above, as:

val sepIndex = zkConnect.indexOf('/')

if (seqIndex > 0) {
  val connect = zkConnect.substring(0, sepIndex)
  val path = zkConnect.substring(sepIndex)
  ... // makeSurePersistentPathExists
}


> When using chroot path, create chroot on startup if it doesn't exist
> --------------------------------------------------------------------
>
>                 Key: KAFKA-404
>                 URL: https://issues.apache.org/jira/browse/KAFKA-404
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8.1
>         Environment: CentOS 5.5, Linux 2.6.18-194.32.1.el5 x86_64 GNU/Linux
>            Reporter: Jonathan Creasy
>              Labels: newbie, patch
>             Fix For: 0.8.1
>
>         Attachments: KAFKA-404-0.7.1.patch, KAFKA-404-0.8.patch, 
> KAFKA-404-auto-create-zookeeper-chroot-on-start-up-i.patch, 
> KAFKA-404-auto-create-zookeeper-chroot-on-start-up-v2.patch, 
> KAFKA-404-auto-create-zookeeper-chroot-on-start-up-v3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to