----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16759/#review31555 -----------------------------------------------------------
For non-detailed description, would it be useful to include #partitions/topics? core/src/main/scala/kafka/api/RequestOrResponse.scala <https://reviews.apache.org/r/16759/#comment60082> It seems that this could be useful for the responses as well in the future to control the client side logging. Could we change that to just describe(details)? For responses, we can just default the implementation to toString() for now. - Jun Rao On Jan. 9, 2014, 7:08 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16759/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 7:08 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1199 > https://issues.apache.org/jira/browse/KAFKA-1199 > > > Repository: kafka > > > Description > ------- > > Included DEBUG and TRACE levels for access logging. At the DEBUG level, all > parts of the request description that are proportional to the number of > partitions or topics is omitted > > > Diffs > ----- > > core/src/main/scala/kafka/api/ControlledShutdownRequest.scala > ad6a20d43f9bba937bc700d40c13945a01f007e8 > core/src/main/scala/kafka/api/FetchRequest.scala > d41a7056e2ad810974018a79ee696f1a6385b721 > core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala > 3401afa05269b402c2d2166a2a3427d46234534e > core/src/main/scala/kafka/api/OffsetCommitRequest.scala > 1cbe6e8de5a83d79b75249e661ccdacadacbb77c > core/src/main/scala/kafka/api/OffsetFetchRequest.scala > a4c5623dbd48d9a0f21b87e39d63cde3604c64a0 > core/src/main/scala/kafka/api/OffsetRequest.scala > 0a94a6c352581774474d32f0539a3055e8fb1bb4 > core/src/main/scala/kafka/api/ProducerRequest.scala > c6063511173649dd8806c78e850f293419b3dc7a > core/src/main/scala/kafka/api/RequestOrResponse.scala > ba59c31a93519eebd24b7a8ad80feea750851025 > core/src/main/scala/kafka/api/StopReplicaRequest.scala > efd704697024456b547f8344fcc535d37fc2ffb8 > core/src/main/scala/kafka/api/TopicMetadataRequest.scala > c5221c4e31a0e18ba435b7801ca0dbed01439677 > core/src/main/scala/kafka/api/UpdateMetadataRequest.scala > 2ead3644eb865be02c52a03ef7671d7466fc4a71 > core/src/main/scala/kafka/network/RequestChannel.scala > 330d3a0df280e2016de254619a0987b6ebee101c > > Diff: https://reviews.apache.org/r/16759/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
