[
https://issues.apache.org/jira/browse/KAFKA-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885869#comment-13885869
]
Neha Narkhede commented on KAFKA-1028:
--------------------------------------
It will be easier to do the review if you can submit a reviewboard request
(Look at
https://cwiki.apache.org/confluence/display/KAFKA/Patch+submission+and+review#Patchsubmissionandreview-Kafkapatchreviewtool)
For now, here is my initial review -
1. KafkaConfig.scala
- Per topic config overrides are handled differently in 0.8.1 through the
command line topic tool which writes the configs to zookeeper. So let's get rid
of the topic overrides here.
- The hope is to pick a config that will convey the impact of turning it on. As
such, I'm not sure if 'unclean leader election' is well understood. But
nevertheless, can we rename it from "replica.unclean.election.enable" to
"unclean.leader.election.enable"?
- The isUncleanElectionEnabled() will need to be removed from here since topic
overrides are not handed through the config object.
2. PartitionLeaderSelector
- We need a way for the controller to load the per topic config overrides for
"unclean.leader.election.enable" from zookeeper. It will use this to mark the
partition offline if it notices that the replicas in ISR are not alive anymore.
> per topic configuration of preference for consistency over availability
> -----------------------------------------------------------------------
>
> Key: KAFKA-1028
> URL: https://issues.apache.org/jira/browse/KAFKA-1028
> Project: Kafka
> Issue Type: Improvement
> Reporter: Scott Clasen
> Assignee: Neha Narkhede
> Attachments: KAFKA-1028.patch
>
>
> As discussed with Neha on the ML.
> It should be possible to configure a topic to disallow unclean leader
> election, thus preventing the situation where committed messages can be
> discarded once a failed leader comes back online in a situation where it was
> the only ISR.
> This would open kafka to additional usecases where the possibility of
> committted messages being discarded is unacceptable.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
