-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17248/
-----------------------------------------------------------
(Updated Feb. 1, 2014, 12:20 a.m.)
Review request for kafka.
Changes
-------
Rebased to trunk:
- Made rack-id optional, default to -1
- Carry max-replication through zookeeper in order to support add-partitions
Missing:
- There is currently no warning when changing a broker's rack-id
- There is no warning during manual replica (re)assignment if the assignment is
not legal under the given max-rack-replication factor
Summary (updated)
-----------------
Patch for KAFKA-1215
Bugs: KAFKA-1215
https://issues.apache.org/jira/browse/KAFKA-1215
Repository: kafka
Description
-------
KAFKA-1226
Diffs (updated)
-----
core/src/main/scala/kafka/admin/AdminUtils.scala a167756
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala 2637586
core/src/main/scala/kafka/admin/TopicCommand.scala 842c110
core/src/main/scala/kafka/client/ClientUtils.scala 1d2f81b
core/src/main/scala/kafka/cluster/Broker.scala 9407ed2
core/src/main/scala/kafka/controller/KafkaController.scala a0267ae
core/src/main/scala/kafka/controller/PartitionStateMachine.scala ac4262a
core/src/main/scala/kafka/server/KafkaApis.scala 29abc46
core/src/main/scala/kafka/server/KafkaConfig.scala 3c3aafc
core/src/main/scala/kafka/server/KafkaHealthcheck.scala 9dca55c
core/src/main/scala/kafka/server/KafkaServer.scala 5e34f95
core/src/main/scala/kafka/utils/ZkUtils.scala b42e52b
core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala 115e203
core/src/test/scala/unit/kafka/admin/AdminTest.scala 59de1b4
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala
8df0982
core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala 9347ea6
core/src/test/scala/unit/kafka/integration/FetcherTest.scala 47130d3
core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala 9998a11
core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala 18e3555
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala 38e3ae7
core/src/test/scala/unit/kafka/utils/TestUtils.scala d88b6c3
examples/README d33f6c5
Diff: https://reviews.apache.org/r/17248/diff/
Testing
-------
File Attachments
----------------
rack_aware_replica_assignment_v1.patch
https://reviews.apache.org/media/uploaded/files/2014/01/23/394cef99-f800-4d94-bc59-fdb6c68b53f5__rack_aware_replica_assignment_v1.patch
Thanks,
Joris Van Remoortere
