----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17649/#review33480 -----------------------------------------------------------
core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java <https://reviews.apache.org/r/17649/#comment62927> Can you fix the whitespace issues? core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java <https://reviews.apache.org/r/17649/#comment62932> Can we try just one producer thread? Also, if you do go with multiple producers then I think you will need to extract the key and if a key is present then send it to the a designated producer thread to ensure ordering within keys. (This is currently done in the existing mirror maker). core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java <https://reviews.apache.org/r/17649/#comment62934> Producers are not shut down cleanly. - Joel Koshy On Feb. 3, 2014, 1:02 a.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17649/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 1:02 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1237 > https://issues.apache.org/jira/browse/KAFKA-1237 > > > Repository: kafka > > > Description > ------- > > Mirror maker using new producer. Does not work for auto created topics > (KAFKA-1238) > > > Diffs > ----- > > bin/kafka-run-class.sh 416ecadf27333d1524518e8229541d161449e282 > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java PRE-CREATION > project/Build.scala ddcfc4176e68933377590e095c07283083249f4a > > Diff: https://reviews.apache.org/r/17649/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
