> On Feb. 7, 2014, 4:53 a.m., Jay Kreps wrote: > > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java, line 25 > > <https://reviews.apache.org/r/17649/diff/7/?file=469305#file469305line25> > > > > I don't think we should have a list of producers. We should just have a > > single producer shared across all mirror threads so that batching is more > > effective.
Yes, thought of that earlier, though not sure how much throughput the producer can currently sustain. To allow us to play with a new settings on the number of producers, added one producer per stream. We can come back and reduce it to a single producer if the throughput is high enough. - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17649/#review33904 ----------------------------------------------------------- On Feb. 4, 2014, 9:12 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17649/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 9:12 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1137 and KAFKA-1237 > https://issues.apache.org/jira/browse/KAFKA-1137 > https://issues.apache.org/jira/browse/KAFKA-1237 > > > Repository: kafka > > > Description > ------- > > Removed the tabs > > > Rebased to new producer API changes > > > removing whitespaces > > > removing whitespaces > > > Joel's review suggestions > > > Mirror maker using new producer. Does not work for auto created topics > (KAFKA-1238) > > > Diffs > ----- > > bin/kafka-run-class.sh 416ecadf27333d1524518e8229541d161449e282 > core/src/main/scala/kafka/tools/newproducer/MirrorMaker.java PRE-CREATION > project/Build.scala ddcfc4176e68933377590e095c07283083249f4a > > Diff: https://reviews.apache.org/r/17649/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
