----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17973/ -----------------------------------------------------------
Review request for kafka. Bugs: KAFKA-1259 https://issues.apache.org/jira/browse/KAFKA-1259 Repository: kafka Description ------- The producer was blocking until requests were sent but not waiting on the response when shutting down. Not how the test ever passed (it is a racy test so probably just good/bad luck) as this has been broken forever. The fix is to wait until all requests are completed. Diffs ----- clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java e8c194c8cdee570f7e3f5a48efa32f5f5c0bc9a4 Diff: https://reviews.apache.org/r/17973/diff/ Testing ------- Thanks, Jay Kreps