----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17987/#review34260 -----------------------------------------------------------
clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java <https://reviews.apache.org/r/17987/#comment64294> This is good, can you break it into another test. Something like testRoundRobinIsFair()? Also can you remove the repeated code. Should be something like val part = partitioner.partition(...) assertEquals((n + i) % 2, part) - Jay Kreps On Feb. 12, 2014, 3:14 a.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17987/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 3:14 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1233 > https://issues.apache.org/jira/browse/KAFKA-1233 > > > Repository: kafka > > > Description > ------- > > KAFKA-1233.followup > > > Diffs > ----- > > > clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java > c78da64b5ad7b0af84baeef12cd9dc3f56e79258 > core/src/test/scala/integration/kafka/api/ProducerSendTest.scala > f8ba361ccf0817435f8c0af28fc2ebf3e5969f3a > > Diff: https://reviews.apache.org/r/17987/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
