-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18740/
-----------------------------------------------------------
(Updated March 5, 2014, 1:57 a.m.)
Review request for kafka.
Bugs: KAFKA-1286
https://issues.apache.org/jira/browse/KAFKA-1286
Repository: kafka
Description (updated)
-------
Incoporated Jun and Jay's comments
KAFKA-1286.v2
Add the failure handling test case
KAFKA-1286.v1
KAFKA-1253.v1
Fix K1258
Debug producer block issue on retry
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
bedd2a989a62b1ed53f006e7e2f8bd1bdc5dfa5b
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
d8e35e7d0e4cd27aad9a8d4bf14bc97458da9417
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
699027447145837495fb56b41ad9ee5e9cb60240
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java
c7fbf3c06858a6016878667b68ee29b22b604f7d
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
794262394133d8e10e52971dccc0082d3aa75047
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java
21a2592ea7c7f5d4831669196cf4e2d2b4e9bcf5
clients/src/main/java/org/apache/kafka/common/requests/MetadataRequest.java
91b9d64aca2255ed3ae1283b2703c7a0f8757a55
clients/src/main/java/org/apache/kafka/common/requests/MetadataResponse.java
73b700602006b881e4be75bb4b6d541e64f291e5
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java
PRE-CREATION
clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java
a3bf07e4ae2daf2c506f4ddff326675dc0de3ee7
core/src/main/scala/kafka/controller/KafkaController.scala
b58cdcd16ffb62ba5329b8b2776f2bd18440b3a0
core/src/main/scala/kafka/log/LogManager.scala
bcd2bb7cb3152f2f6cb99123108fa3a79e393661
core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala
4b7c544594dba734c8875fce2a289f81d67ba291
Diff: https://reviews.apache.org/r/18740/diff/
Testing
-------
integration tests
Thanks,
Guozhang Wang
