> On March 6, 2014, 9 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/producer/ConsoleProducer.scala, line 308 > > <https://reviews.apache.org/r/18712/diff/4/?file=511668#file511668line308> > > > > What about wrap producer configs in propertyOpt to read from a file, > > like ReplayLogProducer did?
Ya, Guozhang, I actually want to propose that change across all the tools. I was thinking of either adding this to the existing tools usability JIRAs or create a new one. Basically, we have quite a few tools that have a set of options relevant to the tool but then also need a way to expose the specific properties of either a consumer and a producer. It makes the tool pretty unwieldy to use if we clutter the tool options with the individual producer/consumer options. What's more, this approach makes it difficult to maintain the tools with every new config we add on our clients. - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18712/#review36425 ----------------------------------------------------------- On March 6, 2014, 12:32 a.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18712/ > ----------------------------------------------------------- > > (Updated March 6, 2014, 12:32 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1281 > https://issues.apache.org/jira/browse/KAFKA-1281 > > > Repository: kafka > > > Description > ------- > > Reverting change to log4j.properties > > > Addressed Jun's review comments. At a high level, this diff changes all tools > to use response.get() when the --sync option is used > > > Found a few problems with the current tools. 1) Moved TestLogCleaning and > TestEndToEndLatency to under tools so we can run those using > bin/kafka-run-class.sh 2) TestLogCleaning seems to hang while sending data > using the new producer. Will file a JIRA to track this > > > First pass at refactoring tools to use the new producer > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java > 307659cf1abacf7933c02e38d0b5a00233bad355 > config/tools-log4j.properties 79240490149835656e2a013a9702c5aa41c104f1 > core/src/main/scala/kafka/producer/ConsoleProducer.scala > 28de57304db6a7c79c4c75de155f6389144eb5a5 > core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala > 42239b27ab26725141f4bf525d2d69538979dd44 > core/src/main/scala/kafka/tools/ReplayLogProducer.scala > 814d61ae477cef5e56723e1f1a86c3b2e9b7c1ea > core/src/main/scala/kafka/utils/CommandLineUtils.scala > 726c30257dcb55b8989163dab3bfc6888dd5d931 > core/src/test/scala/other/kafka/TestEndToEndLatency.scala > f5d39dd71ad25b0d9955d4b9bcdb56ba705abff0 > core/src/test/scala/other/kafka/TestLogCleaning.scala > d20d132de6ef1101a0d8cade9a5417e4286e6117 > > Diff: https://reviews.apache.org/r/18712/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
