> On March 24, 2014, 4:20 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/TopicDeletionManager.scala, line 74 > > <https://reviews.apache.org/r/19577/diff/2/?file=533764#file533764line74> > > > > This is probably trying to fix the problem reported in KAFKA-1307? If > > yes, then this change might not be enough to fix the issue. Since the > > await() and signal would now have to ensure that they lock on deleteLock > > instead of controllerLock.
This is not intended to fix KAFKA-1307. I actually got a deadlock when I just call deleteTopicThread.shutdown in controller shutdown, and took me sometime to finally figure out that I was holding the controllerLock while trying to shutdown the deleteTopicThread, which the thread is awaiting on the same lock's condition. I don't see why the delete Topic manager needs to hold on to the same lock, as the signaling and awaiting seems to be indepedendent of other operations (but I very well can be wrong). Looking at KAFKA-1307 it seems that a patch is submitted for that already? Do we still see issues from that? - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/#review38306 ----------------------------------------------------------- On March 24, 2014, 6:48 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19577/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 6:48 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1317 > https://issues.apache.org/jira/browse/KAFKA-1317 > > > Repository: kafka > > > Description > ------- > > KAFKA-1317 Fix Kafka shutdown with delete topic on > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > f12ffc2af1f739f7d46058c97f0eeed6b55da14d > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > 8262e10ce4364f057e449172ace38320e44247db > > Diff: https://reviews.apache.org/r/19577/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
