[
https://issues.apache.org/jira/browse/KAFKA-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954854#comment-13954854
]
Timothy Chen commented on KAFKA-1350:
-------------------------------------
[~guozhang] the state change logger log call itself isn't guarded, and although
it might not output once it goes into the method, the most expensive call was
actually the string.format that forms the log message overall takes a long time
to process.
> Fix excessive state change logging
> ----------------------------------
>
> Key: KAFKA-1350
> URL: https://issues.apache.org/jira/browse/KAFKA-1350
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8.1
> Reporter: Joel Koshy
> Assignee: Neha Narkhede
> Priority: Blocker
> Fix For: 0.8.1.1
>
> Attachments: KAFKA-1350.patch, KAFKA-1350_2014-03-29_23:28:07.patch
>
>
> I can provide steps to reproduce this issue. The state change logger needs
> to be guarded (to check if trace logging is turned on or not).
> The delete topic patch significantly increased the amount of logging that we
> do both on the controller. This results in higher latencies in state
> transitions and can slow down the controller (as well as the broker). This
> slow-down was how we ran into KAFKA-1342.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
