> On March 31, 2014, 1:40 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 141 > > <https://reviews.apache.org/r/19828/diff/2/?file=540411#file540411line141> > > > > I see what you are saying now. Yes, I think you are right. This patch > > only addresses the conversion to the standard logging trait but the string > > formatting will still happen. > > > > I think this JIRA is filed to fix the actual logging due to the absence > > of the check. I've filed KAFKA-1351 to fix all the String.format uses > > properly, which is a general problem much beyond just the state change > > logger.
Actually if we use the Logging trait the format function would not be called if we are not on that logging level. I did a small test and comment on the jira. - Guozhang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19828/#review39022 ----------------------------------------------------------- On March 30, 2014, 6:29 a.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19828/ > ----------------------------------------------------------- > > (Updated March 30, 2014, 6:29 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1350 > https://issues.apache.org/jira/browse/KAFKA-1350 > > > Repository: kafka > > > Description > ------- > > Converting the request logger to extend from the Logging trait > > > Converting the state change logger to use the Logger trait > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 1087a2e91c86e36a2494a95913a3ec2daf238287 > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > 8ab8ab66bda1e13986df9b88d49199136833de97 > core/src/main/scala/kafka/controller/KafkaController.scala > 2867ef147320c470050256a6b87615e589a7808e > core/src/main/scala/kafka/controller/PartitionStateMachine.scala > c3e8d05102c38045df48936655291bc0f61da84f > core/src/main/scala/kafka/controller/ReplicaStateMachine.scala > 5e016d5d2bbef7fc33fb80c9a4a90ec5d39c16d0 > core/src/main/scala/kafka/network/RequestChannel.scala > a6ec970d72fc8adc56bc6e200d1ff5bbf0d2b748 > core/src/main/scala/kafka/server/KafkaApis.scala > ae2df2014a08aaa95b5eaa430684cfdb79d4f55e > core/src/main/scala/kafka/server/ReplicaManager.scala > 0fe881d22ff8ada9f2596b118e0dbb6f8cd8471c > > Diff: https://reviews.apache.org/r/19828/diff/ > > > Testing > ------- > > Locally tested by monitoring the state change & request log. > > > Thanks, > > Neha Narkhede > >
