----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19853/#review39255 -----------------------------------------------------------
Thanks for the patch. A couple other minor comments below. core/src/main/scala/kafka/producer/ConsoleProducer.scala <https://reviews.apache.org/r/19853/#comment71615> Could we (1) describe valid values for the old producer and (2) remove the part on defaults since now there is no default? core/src/main/scala/kafka/producer/ConsoleProducer.scala <https://reviews.apache.org/r/19853/#comment71616> Instead of duplicating this check in old/new producer, perhaps we can check that the specified compression codec is valid in ProducerConfig? - Jun Rao On April 1, 2014, 4:51 p.m., Ivan Lyutov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19853/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 4:51 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1344 > https://issues.apache.org/jira/browse/KAFKA-1344 > > > Repository: kafka > > > Description > ------- > > [KAFKA-1344] - removed --compress option since it's redundant. Added > --compression-codec argument support to OldProducer as well. > > > [KAFKA-1344] - Added compression codec option feature for ConsoleProducer > > > Diffs > ----- > > core/src/main/scala/kafka/producer/ConsoleProducer.scala > 57386b16988afa17792888fbebb285c174b117f4 > > Diff: https://reviews.apache.org/r/19853/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Lyutov > >
