----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19873/#review39262 -----------------------------------------------------------
The following three metrics are all of percentage, but we use different notations. Could we standardize them to *-perecent? kafka.log.LogCleanerManager.max-dirty-percent kafka.log.LogCleaner.max-buffer-utilization kafka.log.LogCleaner.last-cleaning-recopy-rate core/src/main/scala/kafka/utils/Throttler.scala <https://reviews.apache.org/r/19873/#comment71627> Shouldn't this be measured as a gauge since it's the observed bytes/sec? - Jun Rao On April 1, 2014, 5:41 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19873/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 5:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1327 > https://issues.apache.org/jira/browse/KAFKA-1327 > > > Repository: kafka > > > Description > ------- > > KAFKA-1327 Add log cleaner metrics. > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > b3ab5220a66a2ae82084dad89877daf60f613e66 > core/src/main/scala/kafka/log/LogCleaner.scala > 312204c6ddd0cf46cd7349d79a43edec839bc361 > core/src/main/scala/kafka/log/LogCleanerManager.scala > 43e5c1fd6d9d99f6a47af2136a3d15b9799d4947 > core/src/main/scala/kafka/utils/Throttler.scala > c6c3c75ee8408ca81aeeb5846f7987a287b5a6e8 > > Diff: https://reviews.apache.org/r/19873/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
