[
https://issues.apache.org/jira/browse/KAFKA-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958885#comment-13958885
]
Guozhang Wang commented on KAFKA-1213:
--------------------------------------
Jun, you are right. What I once observed is that the following time sequence
can happen:
1. Broker received normal LeaderAndIsr request from controller (not due to
controlled shutdown)
2. isShuttingDown.get returns false, so move on to adding fetchers.
3. Broker decide to shutdown itself right after the check, set isShuttingDown
to true.
4. Hence broker can be adding fetchers while it is shutting down.
But now I think this is actually fine. Will close the ticket.
> Adding fetcher needs to be avoided upon make-follower when replica manager is
> shutting down
> -------------------------------------------------------------------------------------------
>
> Key: KAFKA-1213
> URL: https://issues.apache.org/jira/browse/KAFKA-1213
> Project: Kafka
> Issue Type: Bug
> Reporter: Guozhang Wang
> Fix For: 0.8.2
>
>
> Today in ReplicaManager.makeFollowers, we check if isShuttingDown.get() is
> false before adding fetchers. However this check cannot avoid adding fetcher
> while at the same time shutting down replica manager since the isShuttingDown
> can be set to false after the check.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
