-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20050/
-----------------------------------------------------------
(Updated April 10, 2014, 5:11 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Fix KAFKA-1359: move producer metrics into a centalized class; fix some bugs in
SenderTest
Bugs: KAFKA-1359
https://issues.apache.org/jira/browse/KAFKA-1359
Repository: kafka
Description (updated)
-------
remove un-used imports
move registration to centralized ProducerMetrics; fixed a small bug in
SenderTest
KAFKA-1359.v2
KAFKA-1359.v1
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
a6423f4b37a57f0290e2048b764de1218470f4f7
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
ffd13ff00ba0d0d969e2ed130e49053f02481b50
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
855ae84f14aa91653b3fa855c2af40560323f42a
clients/src/main/java/org/apache/kafka/common/ProducerMetrics.java
PRE-CREATION
clients/src/main/java/org/apache/kafka/common/network/Selector.java
558f8b47638b354f9c1a30be5d45dc7b61131bea
clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java
a2b77226f8c58caf632a0f4665bd4e4cd93e643d
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
5c5e3d40819e41cab7b52a0eeaee5f2e7317b7b3
Diff: https://reviews.apache.org/r/20050/diff/
Testing
-------
Thanks,
Guozhang Wang
