My bad. The short link `https://shorturl.at/CDNT9` <https://shorturl.at/CDNT9> seems incorrect.
Please use the following instead: https://shorturl.at/bkKQU --- Vito On Fri, Aug 9, 2019 at 10:53 AM Vito Jeng <v...@is-land.com.tw> wrote: > Thanks, Matthias! > > > About `StreamThreadNotStartedException`: > > Thank you for explanation. I agree with your opinion. > `CompositeReadOnlyXxxStore#get()` would never throw > `StreamThreadNotStartedException`. > > For the case that corresponding thread crashes after we handed out the > store handle. We may throw `KafkaStreamsNotRunningException` or > `StateStoreMigratedException`. > In `StreamThreadStateStoreProvider`, we would throw > `KafkaStreamsNotRunningException` when stream thread is not running( > https://shorturl.at/CDNT9) or throw `StateStoreMigratedException` when > store is closed(https://shorturl.at/hrvAN). So I think we do not need to > add a new type for this case. Does that make sense? > > > > About `KafkaStreamsNotRunningException` vs > `StreamThreadNotRunningException`: > > I understand your point. I rename `StreamThreadNotRunningException` to > `KafkaStreamsNotRunningException`. > > > About check unknown state store names: > Thank you for the hint. I add a new type `UnknownStateStoreException` for > this case. > > > > Also, we should still have fatal exception > `StateStoreNotAvailableException`? Not sure why you remove it? > > Thank you point this, already add it again. > > The KIP already updated, please take a look. > > --- > Vito >
