Hi All, It has been a few days so I am closing the vote now.
This KIP has passed with +4 binding votes (Harsha, Manikumar, Jason, Bill) and +3 non-binding votes (Mickael, Maulin, Tom). Regards, Kevin On Fri, Sep 20, 2019 at 1:37 PM Kevin Lu <lu.ke...@berkeley.edu> wrote: > Hi All, > > Thanks for the votes! > > I have to point out that Jason brought up a good point about making the " > *poll-idle-ratio*" measurement consistent with existing broker idle > metrics so we made a small change. > > Previously it was calculated as: > >> poll-idle-ratio = time-between-poll / time-inside-poll > > > We have changed it to: > >> poll-idle-ratio = time-inside-poll / total-time > > > I will leave the vote open for a few more days in case people have > concerns over this change. If there are no issues then, I will close the > vote as we have enough votes. > > Regards, > Kevin > > On Fri, Sep 20, 2019 at 1:33 PM Bill Bejeck <bbej...@gmail.com> wrote: > >> +1 (binding) >> >> Thanks for the KIP! >> >> -Bill >> >> On Fri, Sep 20, 2019 at 1:28 PM Jason Gustafson <ja...@confluent.io> >> wrote: >> >> > +1 Thanks! >> > >> > On Thu, Sep 19, 2019 at 11:22 PM Tom Bentley <tbent...@redhat.com> >> wrote: >> > >> > > +1 (non-binding). >> > > >> > > On Fri, Sep 20, 2019 at 7:00 AM Maulin Vasavada < >> > maulin.vasav...@gmail.com >> > > > >> > > wrote: >> > > >> > > > +1 (non-binding). Thanks for the KIP. >> > > > >> > > > On Thu, Sep 19, 2019 at 10:38 PM Manikumar < >> manikumar.re...@gmail.com> >> > > > wrote: >> > > > >> > > > > +1 (binding), Thanks for the KIP. >> > > > > >> > > > > On Fri, Sep 20, 2019 at 12:41 AM Harsha Chintalapani < >> > ka...@harsha.io> >> > > > > wrote: >> > > > > >> > > > > > +1 (binding). Thanks for the KIP. >> > > > > > >> > > > > > -Harsha >> > > > > > >> > > > > > On Wed, Sep 18, 2019 at 9:07 AM Mickael Maison < >> > > > mickael.mai...@gmail.com >> > > > > > >> > > > > > wrote: >> > > > > > >> > > > > > > +1 (non binding) >> > > > > > > Thanks for the KIP, I can see this being really useful! >> > > > > > > >> > > > > > > On Wed, Sep 18, 2019 at 4:40 PM Kevin Lu < >> lu.ke...@berkeley.edu> >> > > > > wrote: >> > > > > > > > >> > > > > > > > Hi All, >> > > > > > > > >> > > > > > > > Since we have a bit of support, I'd like to start the vote >> on >> > > > > KIP-517: >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-517%3A+Add+consumer+metrics+to+observe+user+poll+behavior >> > > > > > > > >> > > > > > > > Thanks! >> > > > > > > > >> > > > > > > > Regards, >> > > > > > > > Kevin >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> >
