Hi Nikolay, Thank you for the KIP.
I have a couple of minor comments: 1. I would not put implementation details into the KIP as you did with the bodies of the constructor of the `VoidSerde` and the `serialize` and `deserialize` methods. IMO, the signatures suffice. The implementation is then discussed on the PR. 2. I guess you mean that you want to add the `VoidSerde` to the `Serdes` class when you say "I want to add VoidSerde to main SerDe collection.". If my guess is right, then please be more specific and mention the `Serdes` class there. 3. The rejected alternative in the KIP is rather a workaround than a rejected alternative. IMO it would be better to instead list the rejected names for the Serde there if anything. Best, Bruno On Sat, Sep 28, 2019 at 1:42 PM Nikolay Izhikov <nizhi...@apache.org> wrote: > > Hello. > > Any additional comments? > Should I start a vote for this KIP? > > В Вт, 24/09/2019 в 16:20 +0300, Nikolay Izhikov пишет: > > Hello, > > > > KIP [1] updated to VoidSerde. > > > > [1] > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+VoidSerde+to+Serdes > > > > > > В Вт, 24/09/2019 в 09:11 -0400, Andrew Otto пишет: > > > Ah it is! +1 to VoidSerde > > > > > > On Mon, Sep 23, 2019 at 11:25 PM Matthias J. Sax <matth...@confluent.io> > > > wrote: > > > > > > > Because the actually data type is `Void`, I am wondering if `VoidSerde` > > > > might be a more descriptive name? > > > > > > > > -Matthias > > > > > > > > On 9/23/19 12:25 PM, Nikolay Izhikov wrote: > > > > > Hello, guys > > > > > > > > > > Any additional feeback on this KIP? > > > > > Should I start a vote? > > > > > > > > > > В Пт, 20/09/2019 в 08:52 +0300, Nikolay Izhikov пишет: > > > > > > Hello, Andrew. > > > > > > > > > > > > OK, if nobody mind, let's change it to Null. > > > > > > > > > > > > В Чт, 19/09/2019 в 13:54 -0400, Andrew Otto пишет: > > > > > > > NullSerdes seems more descriptive, but up to you! :) > > > > > > > > > > > > > > On Thu, Sep 19, 2019 at 1:37 PM Nikolay Izhikov > > > > > > > <nizhi...@apache.org> > > > > > > > > wrote: > > > > > > > > > > > > > > > Hello, Andrew. > > > > > > > > > > > > > > > > Seems, usage null or nothing is matter of taste. I dont mind if > > > > > > > > we > > > > > > > > call it > > > > > > > > NullSerde > > > > > > > > > > > > > > > > чт, 19 сент. 2019 г., 20:28 Andrew Otto <o...@wikimedia.org>: > > > > > > > > > > > > > > > > > Why 'NothingSerdes' instead of 'NullSerdes'? > > > > > > > > > > > > > > > > > > On Thu, Sep 19, 2019 at 1:10 PM Nikolay Izhikov > > > > > > > > > <nizhi...@apache.org > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > All, > > > > > > > > > > > > > > > > > > > > I'd like to start a discussion for adding a NothingSerde to > > > > > > > > > > Serdes. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-527%3A+Add+NothingSerde+to+Serdes > > > > > > > > > > > > > > > > > > > > Your comments and suggestions are welcome. > > > > > > > > > > > > > > > > > >
