+1 (binding).

Thanks, Jason.

Maybe we should specify that if the configured request.timeout.ms is longer 
than default.api.timeout.ms, the request timeout will be reduced to fit in the 
API timeout.

best,
Colin


On Sat, Nov 23, 2019, at 16:59, Ismael Juma wrote:
> +1 (binding)
> 
> Note that the documentation of the various Options methods will have to be
> updated as it currently mentions "request timeout". An example from
> CreateTopicsOptions:
> 
> "Set the request timeout in milliseconds for this operation or {@code null}
> if the default request timeout for the AdminClient should be used."
> 
> Ismael
> 
> On Fri, Nov 22, 2019 at 1:35 PM Jason Gustafson <ja...@confluent.io> wrote:
> 
> > I'd like to start a vote on KIP-533:
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-533%3A+Add+default+api+timeout+to+AdminClient
> > .
> >
> > +1 from me
> >
> > Thanks,
> > Jason
> >
>

Reply via email to