> On April 19, 2014, 12:22 a.m., Jun Rao wrote: > > core/src/main/scala/kafka/log/LogCleanerManager.scala, lines 83-84 > > <https://reviews.apache.org/r/20468/diff/1/?file=561812#file561812line83> > > > > It seems that we should set the ratio back to 0 if dirtyLogs is empty. > > Otherwise, the reported metrics will stay with the last updated value, > > which can be miss-leading.
Jun, I think you are right on this and the point below. I can follow-up on Monday - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20468/#review40838 ----------------------------------------------------------- On April 17, 2014, 10:33 p.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20468/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 10:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1380 > https://issues.apache.org/jira/browse/KAFKA-1380 > > > Repository: kafka > > > Description > ------- > > KAFKA-1327 Add log cleaner metrics. > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > b3ab5220a66a2ae82084dad89877daf60f613e66 > core/src/main/scala/kafka/log/LogCleaner.scala > 312204c6ddd0cf46cd7349d79a43edec839bc361 > core/src/main/scala/kafka/log/LogCleanerManager.scala > 79e9d556d22c5ecd9be2439e5c54caad9b58735c > core/src/main/scala/kafka/utils/Throttler.scala > c6c3c75ee8408ca81aeeb5846f7987a287b5a6e8 > > Diff: https://reviews.apache.org/r/20468/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
