Hi Anna, Just a minor comment on the wiki page itself:
``` The new method, handleSerializationException, in ProductionExceptionHandler will be invoked when 1. ClassCastException is thrown while serializing record key / value. We will continue to throw this exception and not invoke the new method. ``` I think you meant to say that when ClassCastException is thrown, we would NOT trigger the handler method. But at the beginning it mentioned "will be invoked when.." which sounds a bit conflicting with itself. Could you update the wiki page? Otherwise, I'm +1 on this. Guozhang. On Wed, Jan 15, 2020 at 1:42 PM Matthias J. Sax <matth...@confluent.io> wrote: > Thanks for pushing this KIP over the finish line! > > +1 (binding) > > > -Matthias > > On 1/15/20 12:57 PM, Bill Bejeck wrote: > > Thanks for the KIP. > > > > +1 (binding) > > > > -Bill > > > > On Wed, Jan 15, 2020 at 3:45 PM M. Manna <manme...@gmail.com> wrote: > > > >> +1 (non-binding) > >> > >> Thanks for this KIP > >> > >> Regards, > >> > >> On Wed, 15 Jan 2020 at 20:35, Mitchell <mitche...@gmail.com> wrote: > >> > >>> +1(non-binding) > >>> > >>> Very useful > >>> -mitch > >>> > >>> On Wed, Jan 15, 2020, 3:29 PM Anna McDonald <jbfle...@happypants.org> > >>> wrote: > >>> > >>>> Greetings, > >>>> I would like to propose a vote on KIP-399, extending the > >>>> ProductionExceptionHandler to cover serialization exceptions. This KIP > >>>> is aimed at improving the error-handling semantics in Kafka Streams > >>>> when Kafka Streams fails to serialize a message to the downstream > >>>> sink. > >>>> > >>>> KIP details located here: > >>>> > >>>> > >>> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-399%3A+Extend+ProductionExceptionHandler+to+cover+serialization+exceptions > >>>> > >>>> Discussion Thread: > >>>> > >>>> > >>> > >> > https://lists.apache.org/thread.html/rbbc887ca31d46f6e73ffc6e08df7e4bda69c89ff820986c30274e272%40%3Cdev.kafka.apache.org%3E > >>>> > >>>> Thanks, > >>>> anna > >>>> > >>> > >> > > > > -- -- Guozhang
