Bumping this again for visibility. If no one has any comments, maybe I'll just start the VOTE thread?
On Wed, 2020-01-29 at 22:24 +0000, Thomas Becker wrote: [EXTERNAL EMAIL] Attention: This email was sent from outside TiVo. DO NOT CLICK any links or attachments unless you expected them. ________________________________ Bumping this, hoping to get some additional feedback. ________________________________ From: M. Manna <manme...@gmail.com<mailto:manme...@gmail.com>> Sent: Thursday, January 23, 2020 4:37 PM To: dev@kafka.apache.org<mailto:dev@kafka.apache.org> <dev@kafka.apache.org<mailto:dev@kafka.apache.org>> Subject: Re: [DISCUSS] KIP-566: Add rebalance callbacks to ConsumerInterceptor [EXTERNAL EMAIL] Attention: This email was sent from outside TiVo. DO NOT CLICK any links or attachments unless you expected them. ________________________________ Hey Thomas, On Thu, 23 Jan 2020 at 21:17, Thomas Becker <thomas.bec...@tivo.com<mailto:thomas.bec...@tivo.com>> wrote: Hi folks, I'd like to open the discussion for KIP-566: Add rebalance callbacks to ConsumerInterceptor. We've been looking to implement some custom metrics via ConsumerInterceptor, and not knowing when partition ownership changes is a significant impediment. I'd appreciate your thoughts. https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FKAFKA%2FKIP-566%253A%2BAdd%2Brebalance%2Bcallbacks%2Bto%2BConsumerInterceptor&data=02%7C01%7CThomas.Becker%40tivo.com%7C660a1b4a8ba94d668c7708d7a50a10d3%7Cd05b7c6912014c0db45d7f1dcc227e4d%7C1%7C0%7C637159334967045569&sdata=RYUcrnvDWady9%2FAnLSvc2vvLlchIbj6w0og8Vxe1KN4%3D&reserved=0 I had a quick read through the KIP. I don't see any obvious issues. Sounds like a simple improvement. Perhaps, you could add your thoughts about RebalanceListener API in the future e.g. when to unify the functionality. If implemented, we can simply use one implementation for both things. I would be interested to hear others' comments about this. Thanks, ________________________________ This email and any attachments may contain confidential and privileged material for the sole use of the intended recipient. Any review, copying, or distribution of this email (or any attachments) by others is prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete this email and any attachments. No employee or agent of TiVo is authorized to conclude any binding agreement on behalf of TiVo by email. Binding agreements with TiVo may only be made by a signed written agreement. ________________________________ This email and any attachments may contain confidential and privileged material for the sole use of the intended recipient. Any review, copying, or distribution of this email (or any attachments) by others is prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete this email and any attachments. No employee or agent of TiVo is authorized to conclude any binding agreement on behalf of TiVo by email. Binding agreements with TiVo may only be made by a signed written agreement. -- [cid:9c5eb4be88341189d58cf171e402c865e96c80a8.camel@tivo.com] Tommy Becker Principal Engineer Personalized Content Discovery O +1 919.460.4747 tivo.com<http://www.tivo.com/> ________________________________ This email and any attachments may contain confidential and privileged material for the sole use of the intended recipient. Any review, copying, or distribution of this email (or any attachments) by others is prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete this email and any attachments. No employee or agent of TiVo is authorized to conclude any binding agreement on behalf of TiVo by email. Binding agreements with TiVo may only be made by a signed written agreement.
