Hi Jun, You're right. I have noticed it while implementing it. I plan to use a default value as a sentinel in the protocol (e.g. -2) to cover this case.
David On Wed, Mar 4, 2020 at 3:18 AM Jun Rao <j...@confluent.io> wrote: > Hi, David, > > Thanks for the KIP. +1 from me too. Just one comment below. > > 1. Regarding the sentinel leader epoch to indicate topic deletion, it seems > that we need to use a different sentinel value to indicate that the leader > epoch is not present when the controller is still on the old version during > upgrade. > > Jun > > On Mon, Mar 2, 2020 at 11:20 AM Gwen Shapira <g...@confluent.io> wrote: > > > +1 > > > > On Mon, Feb 24, 2020, 2:16 AM David Jacot <dja...@confluent.io> wrote: > > > > > Hi all, > > > > > > I would like to start a vote on KIP-570: Add leader epoch in > > > StopReplicaRequest > > > > > > The KIP is here: > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-570%3A+Add+leader+epoch+in+StopReplicaRequest > > > > > > Thanks, > > > David > > > > > >
