----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20669/#review41333 -----------------------------------------------------------
Ship it! Good catch! I think moving forward we should 1) make Zookeeper/Server/Producer/ConsumerTestHarness to be able to create multiple instances, 2) enforce all tests to extends these test harnesses when needed, and call super.setup() the first line in setup() and super.teardown() the last line in teardown(). - Guozhang Wang On April 24, 2014, 4:34 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20669/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 4:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1418 > https://issues.apache.org/jira/browse/KAFKA-1418 > > > Repository: kafka > > > Description > ------- > > Close all clients before shutting down the broker in unit tests. > > > Diffs > ----- > > core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala > 2dad20ecc3bbac2ff85c2ce2ce538528111230ae > core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala > 24125e298a563842fe8be8d908a97d9620d7d1bf > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > 1b11eb618e70af4e43055c86e98d5324bb9900a3 > core/src/test/scala/unit/kafka/producer/ProducerTest.scala > c1219a8b9bd1188190cf1f50eec844e97dcd1ba0 > > Diff: https://reviews.apache.org/r/20669/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
