-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20783/#review41627
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On April 28, 2014, 5:24 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20783/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 5:24 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1424
>     https://issues.apache.org/jira/browse/KAFKA-1424
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Rename getPartitionInfos() to getPartitionInfo().
> 
> 
> waitUntilMetadataIsPropagated() needs to Wait until leader in the metadata 
> cache is valid.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/server/MetadataCache.scala 
> a8b7bf74c3630b13bc190f5f7c3d20c341c3d0af 
>   core/src/test/scala/unit/kafka/admin/AdminTest.scala 
> a8d92f678bed7cb36bb29bdeeb772782cc793466 
>   core/src/test/scala/unit/kafka/utils/TestUtils.scala 
> f5a7a5bd92202d805250d9356c8a4e89e6f18732 
> 
> Diff: https://reviews.apache.org/r/20783/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>

Reply via email to