Thanks for making the changes Colin, lgtm! On Mon, 4 May 2020 at 23:13, Colin McCabe <cmcc...@apache.org> wrote:
> Hi Sönke, > > You're right on both counts. Thanks for the corrections. > > Thinking about this more, I think we should just remove > kafka-preferred-replica-election.sh. It just duplicates > kafka-leader-election.sh, and it has been deprecated for some time. I > changed the KIP. > > cheers, > Colin > > On Mon, May 4, 2020, at 01:06, Sönke Liebau wrote: > > Hi Colin, > > > > thanks for the kip, lgtm overall with two small comments: > > > > 1. you mention kafka-leader-election.sh in the list of tools to remove > the > > ZooKeeper option from, but I think the command never had that option, as > it > > was introduced in KIP-460 specifically to replace the deprecated command > > with Zookeeper option. > > > > 2. You mention kafka-preferred-leader-election.sh which is probably just > a > > typo and refers to to kafka-preferred-replica-election.sh ? > > > > Best regards, > > Sönke > > > > [1] > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-460%3A+Admin+Leader+Election+RPC > > > > On Fri, 1 May 2020 at 08:17, Colin McCabe <cmcc...@apache.org> wrote: > > > > > Hi all, > > > > > > I posted a KIP about removing the deprecated --zookeeper flags from our > > > administrative tools. Check it out here: > > > https://cwiki.apache.org/confluence/x/kRARCQ > > > > > > best, > > > Colin > > > > > > > > > -- > > Sönke Liebau > > Partner > > Tel. +49 179 7940878 > > OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany > > > -- Sönke Liebau Partner Tel. +49 179 7940878 OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
