Hi Colin,

The AdminClient should do the hashing, right?  I don't see any advantage to
> doing it externally.


I'm happy so long as the AdminClient interface doesn't require users to do
the hashing themselves.

I do think we should support setting the salt explicitly, but really only
> for testing purposes.  Normally, it should be randomized.
>

>
> I also wonder a little about consistency with the other APIs which have
> > separate create/alter/delete methods. I imagine you considered exposing
> > separate methods in the Java API,  implementing them using the same RPC,
> > but can you share your rationale?
>
> I wanted this to match up with the command-line API, which doesn't
> distinguish between create and alter.
>

OK, makes sense.

Cheers,

Tom

Reply via email to