Based on feedback during code review we made some minor adjustments to the KIP: - clarify that connect group id labels are only included in distributed mode - rename metadata() to contextLabels() in the MetricsContext interface - add context label configuration properties to kafka brokers as well
On Sat, May 9, 2020 at 7:21 AM Randall Hauch <rha...@gmail.com> wrote: > Thanks, Xavier. Looks great. > > On Fri, May 8, 2020 at 7:31 PM Xavier Léauté <x...@apache.org> wrote: > > > > This does seem very useful. A minor request would be to mention the new > > > configs for Connect, Streams and clients, specifically that because > they > > > are optional they will not hinder upgrades, and because they are > > namespaced > > > are unlikely to clash or conflict with other configs from extensions. > > > > > > > Thanks Randall I've updated the compatibility / migration section to > > highlight this information. > > >
