Hi Daniel,

Thanks for working on this KIP.  Proposed changes looks good to me,

minor comments:
1. We use "command-config" option name in most of the cmdline tools to pass
properties file. We can use the same name here.

2. Not sure, if we need a separate option to pass an consumer property.
fewer options are better.


On Wed, Jun 24, 2020 at 8:53 PM Dániel Urbán <urb.dani...@gmail.com> wrote:

> Hi,
> I see that this KIP turned somewhat inactive - I'd like to pick it up and
> work on it if it is okay.
> Part of the work is done, as switching to the Consumer API is already in
> trunk, but some functionality is still missing.
> I've seen the current PR and the discussion so far, only have a few things
> to add:
> - I like the idea of the topic-partition argument, it would be useful to
> filter down to specific partitions.
> - Instead of a topic list arg, a pattern would be more powerful, and also
> fit better with the other tools (e.g. how the kafka-topics tool works).
> Regards,
> Daniel

Reply via email to