Thanks Ron for the additional comments and suggestions. Here are the changes to the KIP: https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=158864763&selectedPageVersions=17&selectedPageVersions=15
On Wed, Jul 29, 2020 at 8:44 AM Ron Dagostino <rndg...@gmail.com> wrote: > > Thanks, Jose. It's looking good. Here is one minor correction: > > <<< If the Kafka topic partition leader receives a fetch request with an > offset and epoch greater than or equal to the LBO (x + 1, a) > >>> If the Kafka topic partition leader receives a fetch request with an > offset and epoch greater than or equal to the LBO (x + 1, b) > Done. > Here is one more question. Is there an ability to evolve the snapshot > format over time, and if so, how is that managed for upgrades? It would be > both Controllers and Brokers that would depend on the format, correct? > Those could be the same thing if the controller was running inside the > broker JVM, but that is an option rather than a requirement, I think. > Might the Controller upgrade have to be coordinated with the broker upgrade > in the separate-JVM case? Perhaps a section discussing this would be > appropriate? > The content set though the FetchSnapshot RPC is expected to be compatible with future changes. In KIP-631 the Kafka Controller is going to use the existing Kafka Message and versioning scheme. Specifically see section "Record Format Versions". I added some wording around this. Thanks! -Jose
